Skip to content

Commit

Permalink
arm64: dts: mediatek: mt8195-demo: fix the memory size of node secmon
Browse files Browse the repository at this point in the history
The size of device tree node secmon (bl31_secmon_reserved) was
incorrect. It should be increased to 2MiB (0x200000).

The origin setting will cause some abnormal behavior due to
trusted-firmware-a and related firmware didn't load correctly.
The incorrect behavior may vary because of different software stacks.
For example, it will cause build error in some Yocto project because
it will check if there was enough memory to load trusted-firmware-a
to the reserved memory.

When mt8195-demo.dts sent to the upstream, at that time the size of
BL31 was small. Because supported functions and modules in BL31 are
basic sets when the board was under early development stage.

Now BL31 includes more firmwares of coprocessors and maturer functions
so the size has grown bigger in real applications. According to the value
reported by customers, we think reserved 2MiB for BL31 might be enough
for maybe the following 2 or 3 years.

Cc: [email protected]      # v5.19
Fixes: 6147314 ("arm64: dts: mediatek: Add device-tree for MT8195 Demo board")
Signed-off-by: Macpaul Lin <[email protected]>
Reviewed-by: Miles Chen <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Matthias Brugger <[email protected]>
  • Loading branch information
macpaul-lin-mtk authored and mbgg committed Dec 16, 2022
1 parent 830b3c6 commit e4a4175
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/mediatek/mt8195-demo.dts
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@
#size-cells = <2>;
ranges;

/* 192 KiB reserved for ARM Trusted Firmware (BL31) */
/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
bl31_secmon_reserved: secmon@54600000 {
no-map;
reg = <0 0x54600000 0x0 0x30000>;
reg = <0 0x54600000 0x0 0x200000>;
};

/* 12 MiB reserved for OP-TEE (BL32)
Expand Down

0 comments on commit e4a4175

Please sign in to comment.