added files for support for mariadb #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignoring mariadb tests Co-authored-by: tornede <[email protected]>
|
The implementation looks good to me: However, there are two nor issues remaining:
|
LukasFehring
requested changes
Apr 21, 2023
There was a problem hiding this comment.
- The branch needs to be rebased on the current state of development
- There is no update in the documentation regarding the supported mariadb connector (I did not see any changes in the documentation). Would write I t myself but I am unsure of any other implications
|
@fmohr This PR did not have any updates for a while. Is this still something you need and are working on? It is outdated and has to be completely reworked due to the latest changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for a new driver in the config file, namely
mariadb. At this moment, this is equivalent to MySQL except that transactions are not declared explicitly.