Add 'address' keyword control binded address #2969 #2974
Conversation
tornado/testing.py
Outdated
| """Binds a server socket to an available port on localhost. | ||
|
|
||
| Returns a tuple (socket, port). | ||
|
|
||
| .. versionchanged:: 4.4 | ||
| Always binds to ``127.0.0.1`` without resolving the name | ||
| Default binds to ``127.0.0.1`` without resolving the name |
There was a problem hiding this comment.
instead of changing this "versionchanged" block, we probably want a separate "versionchanged block, something like:
.. versionchanged:: 6.2
Added optional ``address`` argument to
override the default "127.0.0.1".
There was a problem hiding this comment.
thanks for your review, I got it.
There was a problem hiding this comment.
I think the point was to both keep the original versionchanged and add a new one for the change in this PR.
There was a problem hiding this comment.
I think the point was to both keep the original
versionchangedand add a new one for the change in this PR.
Sorry for my understanding. I think the code is changed and versionchanged should be removed, and I did so in other projects. But I have just read the tornado.concurrent.py, I find it leaves all previous versionchanged. This is the tornado style, I am pleased to obey it.
|
Thanks! |
Specify custom address by "address" keyword when use
tornado.testing.bind_unused_portfunction.