Edit as YAML buttons are broken in all resource edit page.
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
changed the title
Edit as YAML button is broken in all resource edit page.
a110605
changed the title
Edit as YAML button is broken in all resource edit page.Edit as YAML buttons are broken in all resource edit page.
torchiaf
force-pushed
the
feature/harvester-extension
branch
from
c311ea2 to
4f4e074
Compare
Signed-off-by: andy.lee <[email protected]>
a110605
force-pushed
the
fix_edit_as_yaml
branch
from
94b18ce to
0f02fd2
Compare
|
We fixed the same issue in the current Harvester UI where we needed a porting of the schemaDefinitions changes from Rancher: harvester#1208 Closing current issue in favor of this commit, which will fix this issue and the other Yaml views when handling Rancher resources: torchiaf/harvester@3887ca7 We don't need to port anything else since we are importing the shell library which contains the schemaDefinitions handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Edit as YAMLbutton is broken in all resource edit page.After Fix