Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indonesian (id) translations #301

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Add Indonesian (id) translations #301

merged 5 commits into from
Jun 26, 2023

Conversation

kiraware
Copy link
Contributor

Add Bahasa Indonesia support

Copy link
Contributor Author

@kiraware kiraware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review @Andrew-Chen-Wang

@Andrew-Chen-Wang
Copy link
Member

thank you tho the file doesn't seem complete, and it'd be great if you generated the mo file. thanks!

@kiraware
Copy link
Contributor Author

Actually the .mo file is being ignored by .gitignore, that is the reason why i don't add it. My last commit add the .mo file. Thanks @Andrew-Chen-Wang for your response!

@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Jun 25, 2023

oh thank you. sorry i'm mixing up oss projects. please remove mo file

@kiraware
Copy link
Contributor Author

Never mind @Andrew-Chen-Wang. Thanks for your fast response. Done revert the commit.

@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Jun 25, 2023

sorry this is super annoying but can u revert that commit again and add back the mo file.

in the gitignore can u also remove the *mo entry. I see that the mo files are actually inside the package

@kiraware
Copy link
Contributor Author

It's OK. Done @Andrew-Chen-Wang

@Andrew-Chen-Wang
Copy link
Member

thanks again!

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit d492545 into django-recaptcha:main Jun 26, 2023
@kiraware kiraware deleted the add-id-translations branch June 27, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants