Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent API behavior of potri in cutorch vs torch #596

Closed
killeent opened this issue Nov 11, 2016 · 0 comments
Closed

inconsistent API behavior of potri in cutorch vs torch #596

killeent opened this issue Nov 11, 2016 · 0 comments

Comments

@killeent
Copy link
Contributor

killeent commented Nov 11, 2016 •
edited
Loading

Torch's potri function expects a call to potrf first:

https://github.com/torch/torch7/blob/master/doc/maths.md#torchpotrires-chol--u-or-l-

However, we call potrf internally in cutorch's implementation of potri:

https://github.com/torch/cutorch/blob/master/lib/THC/THCTensorMathMagma.cu#L459

Thus we cannot convert a tensor to its corresponding cuda type and expect the same behavior from subsequent API calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@killeent