Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically patch desired annotations on STS-provisioned PVCs from the STS spec #304

Open
sam-mcbr opened this issue Jan 27, 2025 · 1 comment
Assignees

Comments

@sam-mcbr
Copy link
Contributor

What should the feature do:
Monitor StatefulSet volumeClaimTemplates for any pvc-autoresizer configuration annotations (resize.topolvm.io/storage_limit, resize.topolvm.io/threshold, resize.topolvm.io/inodes-threshold, resize.topolvm.io/increase, resize.topolvm.io/initial-resize-group-by), and patch any existing associated PVCs with these annotations.

What is use case behind this feature:
For existing PVCs created via a StatefulSet volumeClaimTemplate, it is impossible to add annotations to PVC without either deleting it or manually patching the annotations on. This largely defeats the usefulness of the pvc-autoresizer for STS-provisioned PVCs (when running a large number of them) because even if the annotations are applied to the PVCs, any future changes to the values will require further manual deletions/patches.

Our team specifically has a significant number of STS-provisioned PVCs that already exist and it would be a significant amount of work to apply the annotations required to start using the pvc-autoresizer we have deployed. Having this feature built-in to the pvc-autoresizer controller would drastically simplify our adoption and deployment of the project.

Happy to discuss this use-case further and would love to hear your thoughts!

@llamerada-jp llamerada-jp moved this from To do to In progress in Development Jan 28, 2025
@llamerada-jp llamerada-jp self-assigned this Jan 28, 2025
@sam-mcbr
Copy link
Contributor Author

@llamerada-jp If you all think this would be a nice feature to add, we are happy to work on the PR for it. This is a blocker to us utilizing the pvc-autoresizer we recently deployed so we are happy to pick this up and start work right away 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

2 participants