Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where node docker container can't find the binaries for tsx and vitest #24

Closed
d-roak opened this issue Jun 23, 2024 · 0 comments
Closed

Fix a bug where node docker container can't find the binaries for tsx and vitest #24

d-roak opened this issue Jun 23, 2024 · 0 comments
Labels
bug Something isn't working external contributors Open for external contributors

Comments

@d-roak
Copy link
Member

d-roak commented Jun 23, 2024

It seems the initial install is doing a link to a wrong folder (might be because of the node being in a workspace)
image

Relevant files to change:
remove the install from here
https://github.com/topology-foundation/ts-topology/blob/66b89ba64b088d0b7d5c0009081fcc6e0e55338f/packages/node/entrypoint.sh#L2
add it here
https://github.com/topology-foundation/ts-topology/blob/66b89ba64b088d0b7d5c0009081fcc6e0e55338f/packages/node/Dockerfile#L1-L8
@d-roak d-roak added bug Something isn't working good first issue external contributors Open for external contributors labels Jun 23, 2024
@d-roak d-roak moved this from Triage to 🗃️ Backlog in Project Management Jul 5, 2024
@d-roak d-roak closed this as completed Jul 26, 2024
@github-project-automation github-project-automation bot moved this from 🗃️ Backlog to 🏆 Done in Project Management Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working external contributors Open for external contributors
Projects
Project Management
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d-roak