From cd58082fa599faa5f7f02df9a30088de6c03769e Mon Sep 17 00:00:00 2001 From: Oak Date: Wed, 6 Nov 2024 04:24:34 +0000 Subject: [PATCH] ci: refactor perms and change output summaries (#237) --- .github/workflows/benchmark.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 61130d50..e6cf97b2 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -8,13 +8,11 @@ on: permissions: pages: write id-token: write - pull-requests: write + contents: write jobs: benchmark: name: Run benchmark - permissions: - pull-requests: write runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -26,8 +24,6 @@ jobs: pnpm install --no-frozen-lockfile cd packages/object pnpm run benchmark - # possible lockfile and version.ts changes - git stash - name: Set cache dir uses: actions/cache@v4 @@ -44,7 +40,8 @@ jobs: output-file-path: packages/object/benchmark-output.txt alert-threshold: "200%" fail-on-alert: true - comment-always: true + comment-on-alert: ${{ github.event_name == 'push' }} + summary-always: true gh-pages-branch: main skip-fetch-gh-pages: ${{ github.event_name == 'push' }} benchmark-data-dir-path: ./cache/benchmarks