fix(zygisk): Fix Zygisk on GrapheneOS Android 14

[pixincreate]

The discussions have been done in these places:

• 2023112600 build of GrapheneOS causes bootloop if Magisk is installed as system server crashes chenxiaolong/avbroot#213
• Magisk 26.4 Zygisk fails on Pixel 7a GrapheneOS Android 14 231105.003 #7593
• Magisk won't work and Zygisk won't enable on latest GrapheneOs for Pixel 7 #7589
• Zygisk not enabling on GrapheneOS HuskyDG/magisk-files#20

And specially this

GrapheneOS code changes can be seen here

P.S: I don't have any context about how Magisk works at core level. I cherry-picked HuskyDG's commit and modified it to make it work with Magisk.

Tests are run here and test on 34 failed.

[pixincreate]

Ok, kindly update your Magisk's documentation explaining what operating systems / devices are supported (since the vision of Magisk today seems to cover basically the topline Pixel models running stock OS, Samsung devices and nothing else) so that we don't waste our time trying to fix it in here or ask for support.

To what I understand, @topjohnwu never had a vision of making this project to target only specific OSes but rather had a broad vision of a project that serves an entire open source android community.

[Robotition]

literally why was this closed? this PR properly fixes GrapheneOS support

[Robotition]

perhaps someone could fork?

[canyie]

GrapheneOS hates root and any modification, No reason to be compatible with operating systems that hate us.

[Robotition]

Maybe because GrapheneOS is a properly hardened Operating system? People are free to root their device if they please while still having a more secure rooted experience than on AOSP.

[yujincheng08]

Magisk wont make extra effort to support any specific customized ROM. Otherwise anyone can create a customized ROM that breaks Magisk and Magisk has to constantly update to support it.

Basically, Magisk tries its best to support most OEM OSes (unless those intentionally anti-root, e.g. vivo's OSes). As for customized ROMs, well, since Magisk will try to make sure it works on their upstreams, they can easily avoid breaking Magisk. If they still break Magisk, it means they dont care about, or even they are aganist Magisk. In that case, there's no reason for Magisk to still add special support.

[pixincreate]

GrapheneOS hates root and any modification, No reason to be compatible with operating systems that hate us.

There's nothing termed as "hating root" or "hating you". It is just that the project's threat model asks for it to be avoided. However but that does not mean that users of GrapheneOS should be deprived of root just because upstream does some changes with the way a certain feature work.

Magisk wont make extra effort to support any specific customized ROM. Otherwise anyone can create a customized ROM that breaks Magisk and Magisk has to constantly update to support it.

I agree with this to an extent. But Magisk has also down significant efforts to make it compatible with Samsung devices that contradicts with what is mentioned above. Samsung did do a lot of stuffs that goes against Magisk but still Magisk was made to support it unlike in other cases like Vivo (FuntouchOS).

[yujincheng08]

Samsung's OSes are OEM OSes, so Magisk will try to support. For VIVO, we have tried but with no luck, otherwise VIVO devices are supported.

[pixincreate]

Why not GrapheneOS? Of course it is not an OEM, neither it is an after market Operating System but rather an alternate Operating System that supports verified boot. I'm saying this after using using it for more than 10 months and it feels like an OS from an OEM given that it is always up-to-date (they did support Android 14 within 4 -5 days of it being released into public way too early than any other OEM out there after Google, in case you're unaware) unlike other custom ROMs.

[canyie]

Maybe because GrapheneOS is a properly hardened Operating system? People are free to root their device if they please while still having a more secure rooted experience than on AOSP.

GrapheneOS/platform_frameworks_base@9a9282b
They introduce changes that would even break normal apps for their so-called "security". Why we should take effect to support a custom system that even doesn't pass CTS? Only systems that comply with the Android Compatibility Definition Document are Android.

[pixincreate]

They introduce changes that would even break normal apps for their so-called "security".

I agree with this, and they're doing their stuff of trying to make it work with normal apps and I don't talk about that.

Only systems that comply with the Android Compatibility Definition Document are Android.

Any OS that is built on top of AOSP is Android. Android CDD is a requirement documentation that has to be met to make a certain version of Android say 14 compatible and it is what the first itself states:

This document enumerates the requirements that must be met in order for devices to be compatible with Android 14.

And there is no where mentioned that systems that comply with Android CDD only has to be considered Android.

CTS is exected to not pass as GrapheneOS is not a partner of Google by any means to get approval to get Play Services running.

Sources:
https://source.android.com/docs/compatibility/14/android-14-cdd
https://developer.android.com/google/play/integrity/verdicts

[yujincheng08]

Why not GrapheneOS? Of course it is not an OEM, neither it is an after market Operating System but rather an alternate Operating System that supports verified boot.

not a reason to support. every customized rom can highlight their feature.

and, as i hv said, if its built upon AOSP, they can avoid breaking magisk (because magisk supports AOSP). if they really break magisk, that means they dont care about magisk. you should ask them to avoid breaking magisk (or submit their so-called security changes to AOSP), rather than begging here.