fix(poetry): parse arg in script shebang line #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThePeanut4
force-pushed
the
fix-poetry-fedora
branch
from
8cb5d47 to
36abea6
Compare
|
Thanks for the patch! @AThePeanut4 cc @tsvikas, here is a build for Linux with this patch included, welcome to give it a test: https://github.com/SteveLauC/topgrade/releases/tag/pr1028 |
AThePeanut4
force-pushed
the
fix-poetry-fedora
branch
from
36abea6 to
361f3f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Parse the shebang line in the poetry wrapper script to ignore leading spaces, and split out any arguments, so that e.g.
#! /usr/bin/python3 -sPdoesn't error. On Windows, take into account the possibility that the interpreter path may be double-quoted so that it can contain spaces.Fixes #1021
Standards checklist
[CONTRIBUTING.md](http://contributing.md/)