Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending spurious Rejects when processing remote account deletion #15104

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@@ -62,7 +63,7 @@ def call(account, **options)
private

def reject_follows!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, let me think... This made sense when this was SuspendAccountService, but do we actually ever need to do this when we're deleting now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, this is already done in SuspendAccountService, but some codepaths skip this, such as blocking a domain altogether.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense.

@Gargron
Copy link
Member

Gargron commented Nov 8, 2020

We've got :skip_side_effects and now also :skip_activitypub, this will likely cause confusion in the future. Can we:

  • Make the behaviour part of already existing :skip_side_effects or
  • Make the name more specific like :skip_reject_follows?

@ClearlyClaire
Copy link
Contributor Author

:skip_side_effects also skips sending streaming events, which we don't want to do here
:skip_reject_follows might not be the best because I also want to undo outgoing follows here

@ClearlyClaire
Copy link
Contributor Author

:skip_side_effects could imply :skip_activitypub but those two should be different things

@ClearlyClaire ClearlyClaire force-pushed the fixes/do-not-send-unfollow-on-account-deletion branch from 1cbe4ba to e043d95 Compare November 13, 2020 18:23
@gigamaster

This comment has been minimized.

@ClearlyClaire ClearlyClaire force-pushed the fixes/do-not-send-unfollow-on-account-deletion branch from e043d95 to 4a3f41f Compare November 16, 2020 12:47
@Gargron Gargron merged commit 2f6831f into mastodon:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants