Make “Mark media as sensitive” properly translatable #15051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariasuni
force-pushed
the
make-mark-media-as-sensitive-properly-translatable
branch
from
22ff261 to
639048a
Compare
ariasuni
force-pushed
the
make-mark-media-as-sensitive-properly-translatable
branch
from
639048a to
31af20e
Compare
Gargron
approved these changes
Oct 27, 2020
ariasuni
deleted the
make-mark-media-as-sensitive-properly-translatable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“Mark media as sensitive” is a single string for both singular and plural (that is, when there is one media or several). However, in a lot of languages, it would be clearer if the string is different when there is one media or several. Right, in French the string is always singular and in Esperanto it is always plural, but it’s less than ideal.
With this PR, you can translate with a different string for singular and plural, like it should be.