Fix admins being able to suspend their instance actor #14567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/suspended-instance-actor
branch
from
be81b8b to
6c0ffb4
Compare
Gargron
requested changes
Aug 24, 2020
ClearlyClaire
force-pushed
the
fixes/suspended-instance-actor
branch
from
6f83370 to
4b4ca8a
Compare
|
ping @Gargron |
|
Back-end changes are good but what if instead of adding a flash message which made this account not show up in accounts list, make its name unclickable in places where it appears, and made it impossible to view its account page? |
|
hm… it's possibly a lot of places, though… |
ClearlyClaire
force-pushed
the
fixes/suspended-instance-actor
branch
from
4b4ca8a to
c744fd5
Compare
|
Rebased and made it so the instance actor doesn't show up in the accounts list in moderation view. It could show up in other parts but I think that's fine. Kept the flash message in case someone stumbles upon it. |
ClearlyClaire
force-pushed
the
fixes/suspended-instance-actor
branch
from
c744fd5 to
9ae10ae
Compare
Gargron
reviewed
Nov 27, 2020
ClearlyClaire
force-pushed
the
fixes/suspended-instance-actor
branch
from
9ae10ae to
089368c
Compare
Gargron
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how, but I've seen a couple admins manage to suspend their instance actor (which cause federation issues).
This PR:
Account#suspend!do nothing on the instance actorAccount#suspend?return false no matter what on the instance actor