Add tootctl media remove-orphans
#12568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gargron
commented
Dec 8, 2019
Gargron
commented
Gargron
force-pushed
the
feature-tootctl-media-remove-orphans
branch
6 times, most recently
from
5edff69 to
49a1dd4
Compare
nightpool
approved these changes
Dec 8, 2019
| @@ -89,7 +89,7 @@ | |||
| Paperclip::Attachment.default_options.merge!( | |||
| storage: :filesystem, | |||
| use_timestamp: true, | |||
| path: ENV.fetch('PAPERCLIP_ROOT_PATH', ':rails_root/public/system') + '/:class/:attachment/:id_partition/:style/:filename', | |||
| path: File.join(ENV.fetch('PAPERCLIP_ROOT_PATH', File.join(':rails_root', 'public', 'system')), ':class', ':attachment', ':id_partition', ':style', ':filename'), | |||
There was a problem hiding this comment.
*%w(:rails_root public system) can clean up these arg lists
| progress = create_progress_bar(nil) | ||
| reclaimed_bytes = 0 | ||
| removed = 0 | ||
| dry_run = options[:dry_run] ? ' (DRY RUN)' : '' |
There was a problem hiding this comment.
maybe we should make this :destructive so it's opt in instead of opt out?
There was a problem hiding this comment.
or maybe we should gather all the files to delete, ask for confirmation, and then delete them
There was a problem hiding this comment.
I wouldn't do that because of memory implications if there are a lot of files as well as being able to interrupt the process while having some kind of tangible progress.
Gargron
force-pushed
the
feature-tootctl-media-remove-orphans
branch
3 times, most recently
from
c3ef226 to
2bf3ecb
Compare
Gargron
force-pushed
the
feature-tootctl-media-remove-orphans
branch
from
2bf3ecb to
11a34e9
Compare
|
Thanks for this |
rtucker
referenced
this pull request
in vulpineclub/mastodon
Jan 7, 2021
rtucker
referenced
this pull request
in vulpineclub/mastodon
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.