Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use |- ligature when part of |-| #713

Closed
andOlga opened this issue Feb 12, 2019 · 4 comments
Closed

Do not use |- ligature when part of |-| #713

andOlga opened this issue Feb 12, 2019 · 4 comments
Labels
Milestone

Comments

@andOlga
Copy link

andOlga commented Feb 12, 2019

The |-| sequence of characters is used in Markdown tables to separate the header of the table from the contents, e.g.:

|Column 1|Column 2|
|-|-|
|R1C1|R1C2|
|R2C1|R2C2|

Currently, Fira code applies the |- ligature here, resulting in this, which looks entirely wrong:
image

@tonsky
Copy link
Owner

tonsky commented Feb 12, 2019

thanks, will adjust!

@tonsky tonsky added this to the 1.208 milestone Aug 27, 2019
@tonsky tonsky closed this as completed in 707ba48 Sep 2, 2019
@AnandChowdhary
Copy link

@tonsky, this could be an interesting exploration of Fira Code ligatures for markdown. Also curious about your thoughts, @ooa113y.

Current behavior:

Screen Shot 2020-11-23 at 14 48 21

With proposal ligatures:

Group 55

I understand that multi-line ligatures might be impossible, but maybe something like this?

Group 56

This can be ligatures for | - and - |, for example. Also, - | - could render to something similar to a wider +.

If this is something you'd consider, I can open another issues to discuss it further.

@wopian
Copy link
Contributor

wopian commented Nov 23, 2020

@AnandChowdhary: I understand that multi-line ligatures might be impossible, but maybe something like this?

I don't think this is a good idea for a ligature.

I would have no idea if I (or the previous committer) typed | -- | -- | or |----|----|, which could lead to people committing something like | -- |--- | ---| unintentionally.

And for myself, it would make resolving a linter error annoying where a space between table columns is required in my projects. |---| would throw an error, which wouldn't be obvious from looking as it would be visually identical to | - |.

@tonsky
Copy link
Owner

tonsky commented Nov 23, 2020

Current Fira Code should render like this:

Screen Shot 2020-11-23 at 13 38 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants