Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$, & and @ (and maybe <= and >=) #617

Closed
Vampire opened this issue Jun 26, 2018 · 19 comments
Closed

$, & and @ (and maybe <= and >=) #617

Vampire opened this issue Jun 26, 2018 · 19 comments
Milestone

Comments

@Vampire
Copy link
Contributor

Vampire commented Jun 26, 2018

I just started using Fira Code.
It is really great having those font ligatures.
But I actually dislike how $, & and @ look there.
I found that your work is based on Fira Mono.
Now I have seen that in normal Fira, these look nice and only look unnice in Fira Mono:
grafik
I created an issue for Fira, but now found that the font is not developed any further but got abandoned.

Would it be possible to change the Fira Code ones to look more like the ones in normal Fira?
Or maybe as variants like it is for Monoid where you can select different representations for some characters on download?

If such choices get implemented also <= and >= would be candidates, so that the two bottom lines or maybe only the bottom line are horizontal and not angeled. :-) I somehow feel grafik or grafik look better than grafik, but that is a matter of taste of course.

@j-f1
Copy link
Contributor

j-f1 commented Jun 26, 2018

For the <= ligature, I believe it looks the way it does to avoid problems with differentiating between it and the actual character.

@tonsky
Copy link
Owner

tonsky commented Jun 26, 2018

If I ever implement a system that would allow you to pick different variant these would be among the first one yes. Thanks for the suggestion

@Vampire
Copy link
Contributor Author

Vampire commented Jun 26, 2018

In what rough timeframe would "ever" be? 😁

If the tool you use wouldn't cost that much money I'd probably look into how complex it is to change this for me, but if it only works for 30 days, it is not feasible to start this and then not being able to rebase onto new updates.

I never touched any font files, is it hard to do theses changes and if not selectable like for Monoid, maybe with different pre-compiled variants?

(While I guess it is pre-compiled for Monoid too and the selector just decides which file to download.)

@Vampire
Copy link
Contributor Author

Vampire commented Jun 26, 2018

If I could do anything to help you support this (besides buying a Mac and Glyph2), I might do so maybe.

@Vampire
Copy link
Contributor Author

Vampire commented Jun 28, 2018

For anyone interested, here are the 1.205 FiraCode TTF variants with the $, & and @ standard glyphs and the <$, <$>, $>, <=, >= and && ligature glyps replaced.

I think the $-based and =-based and the && look quite nice even in detail.

For the & and @ I basically took the respective FiraSans versions and made them narrower to fit in the monospace width, so in detail they look a bit shitty, but for normal sizes that are used when writing or reading code the niceness is acceptable. :-)

FiraCode-TTF-with-replaced-glyphs.zip

@mickeyl
Copy link

mickeyl commented Oct 3, 2018

@Vampire Thanks for your contribution, that's great. I'd like to add them to my fork. Could you share your modifications in source form?

@Vampire
Copy link
Contributor Author

Vampire commented Oct 3, 2018

Nope, I used a font editor to edit the TTFs by hand, so I don't have any source modifications. All I have is the TTFs.

@853419196
Copy link

@Vampire I think this is a great suggestion and I hope that your proposal can be taken seriously and implemented.

tonsky added a commit that referenced this issue Sep 2, 2019
tonsky added a commit that referenced this issue Sep 3, 2019
@tonsky tonsky closed this as completed in c21b830 Sep 3, 2019
@tonsky tonsky added this to the 1.208 milestone Sep 3, 2019
@Vampire
Copy link
Contributor Author

Vampire commented Sep 3, 2019

Great @tonsky, much thanks.
When can we expect a version with these changes?
I'm eager to have a look. :-)

@tonsky
Copy link
Owner

tonsky commented Sep 3, 2019

Hope to get it out there in a few days

@Vampire
Copy link
Contributor Author

Vampire commented Sep 3, 2019

Another question, does the "stylistic sets" mean you now did the system that would allow you to pick different variant you mentioned, or did you just hard changed the glyphs for all?

@j-f1
Copy link
Contributor

j-f1 commented Sep 3, 2019

I believe it’s the former.

@Vampire
Copy link
Contributor Author

Vampire commented Sep 3, 2019

Ah, I see, stylistic sets are a feature of the font files.
I hope these can be selected on download, I see neither in Firefox, nor in IntelliJ IDEA an option to select stylistic sets.
Or I misunderstood how those are used / applied.

@tonsky
Copy link
Owner

tonsky commented Sep 3, 2019

Stylistic sets are variants of glyphs embedded into the font under different names. They co-exist with the default glyphs, which I didn’t change. Some apps let you choose which sets you want to enable.

In CSS:

font-feature-settings: "ss01", "ss02";

In Sublime Text:

"font_options": ["ss01", "ss02"]

In Atom:

atom-text-editor {
  font-feature-settings: "ss01", "ss02", "ss03", "ss04", "ss05", "ss06", "ss07";
}

In some Apple apps:

Screenshot 2019-09-03 at 16 49 46

In VS Code:

Via editing ectron-browser/index.html https://marketplace.visualstudio.com/items?itemName=be5invis.vscode-custom-css

Adobe apps, MS Word etc:

https://www.macworld.com/article/3052388/how-to-access-advanced-opentype-features-in-a-variety-of-mac-apps.html

Customizing font on download would be a much better solution but it requires much more effort to implement. One day I hope to get there.

@Vampire
Copy link
Contributor Author

Vampire commented Sep 3, 2019

Is there maybe some tool that could enable those stylistic sets per default you are aware of or similar?
As I said, neither Firefox, nor IntelliJ IDEA which are the two main tools where I use the font have such a setting as far as I can see.

@mickeyl
Copy link

mickeyl commented Sep 3, 2019

„Customizing font on download would be a much better solution“. I disagree – Stylistic Sets are exactly the right Choice for such a feature. For some users, a customizable download may be better, but not in general.

Thanks for implementing this the right way!

@Vampire
Copy link
Contributor Author

Vampire commented Sep 3, 2019

I didn't say it is not the right way, I just said it would be nice for usage in software where you cannot enable stylistic sets.
I found https://github.com/twardoch/fonttools-opentype-feature-freezer/ which might do what I want.

@Vampire
Copy link
Contributor Author

Vampire commented Sep 3, 2019

Actually in Firefox I use a userscript anyway to force FiraCode for websites, so there I could actually use the stylistic sets probably.

@Vampire
Copy link
Contributor Author

Vampire commented Sep 9, 2019

@tonsky you missed the <$, <$> and $> ligatures for the ss04 and shouldn't maybe the && with ss03 look more like grafik than like grafik?

This was referenced Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants