-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison ligatures & Ligature Request +=, -= #416
Comments
Thanks Tony! There’s a ligature for |
@tonsky I know about the |
I actually like them, but I know a lot of other people don’t. Would it be better if it were more balanced, instead of (depending on font size) the bars not being equally spaced? |
@zeg-io I know what you mean, actually. Maybe I’ll think of something eventually |
I already have enough trouble telling the differences between |
Well, the option listed there (bold with a little pip cut out) might work too. Maybe two cut outs for the === sign? I actually believe that the double-thick equals stands out pretty clearly, but I'd go for almost any other solution ;) |
The fact it stands out while bold shows it's not coherent with the rest of the typeface 🙁 Besides that, the triple barred |
Thanks for this font! I switched to Fira Code from DejaVu Sans Mono. I code a lot of C and C++, and I miss the balanced "+=" and "-=" which are used a lot there. In Fira Code, they look unbalanced (the "+" and "-" is not centered vertically on the "="). So even if you won't add ligatures for these, it would be nice to have the "=" centered regardless. It just looks completely off compared to DejaVu Sans Mono. |
OK, never mind. I deleted the *.ttf versions of the fonts and instead installed the *.otf files. "+=" and "-=" now look centered. No idea what's causing this though. Is there a difference in the fonts themselves, or does FreeType (I'm on Linux) render these differently? |
@realnc it’s probably a feature conflict there. I have a “aligned math” feature when math operators (+, -, *, = etc) align slightly differently if surrounded by lowercase letters. So if you type |
@tonsky Weird thought that it appears to behave differently between the TTF and OTF version. Generally, which should be preferred? (I would assume OTF is the better format compared to TTF?) Edit: Also, usually "+=" (and friends) is used with spaces around it. That is "a += 2" instead of "a+=2". (Or at least if not "usually" then "by many people.") |
I’m under impression that OTF works better on Mac and TTF works better on Windows but I wound’t vouch for it. In theory, both formats support all the features |
I would also like to voice my support for += and -= ligatures. Other than that, I love everything about this font. Thanks to all the contributors. |
With the recently added support for ligatures on Sublime Text, adding ligatures for I have no idea, though how the ligatures for those symbols should look like. |
there already is a ligature for /=, so i'd say *= could also get one. |
@tonsky Love the font! Not a huge fan of the === and !== (triple-line) It doesn't look as elegant as the => and == and != symbols. Are you open at all to modifying it? Not exactly sure what font capabilities are, but maybe a "bold" version of the == and != rather than triple line?
Also, not sure what it could look like, but "coolness factor" demands a ligature for
+=
and==
:)Maybe a
+
in the middle of an=
so it looks something like=[+]=
and=[-]=
but taking up two symbols, not 5 ;)Anyway, I know everyone has opinions. Thanks for taking the time to read mine. And thanks again for the awesome font!
The text was updated successfully, but these errors were encountered: