Web support, better round robin engine #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why this PR still not reviewed? |
TrueCarry
force-pushed
the
truecarry/adnl-client
branch
from
b9d2103 to
7257732
Compare
dvlkv
requested changes
Feb 21, 2023
| throw e | ||
| } | ||
|
|
||
| await delay(100) |
There was a problem hiding this comment.
Probably need to use timeout from arguments
src/engines/single.ts
Outdated
| @@ -161,6 +189,6 @@ export class LiteSingleEngine implements LiteEngine { | |||
| if (!this.#closed) { | |||
| this.connect(); | |||
| } | |||
| }, 1000); | |||
| }, 10000); | |||
There was a problem hiding this comment.
Maybe do this configurable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local implementation of adnl changed to original. Now it has support for tcp:// and ws:// transports. Because of that new engine api changed, maybe time to make 2.0.0 release.
Random bytes imported from tweetnacl instead of crypto, since it's hard to include crypto for browsers and tweetnacl already used in most ton libs.
Round robin engine now uses incremental server select. Also it checks if connection is open to avoid timeouts that we aware of beforehand and retries on errors. It allows to not retry calls when using lib in client/server code.