Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAStackView #2

Closed
pjebs opened this issue Jun 21, 2015 · 5 comments
Closed

OAStackView #2

pjebs opened this issue Jun 21, 2015 · 5 comments

Comments

@pjebs
Copy link

pjebs commented Jun 21, 2015

I was wondering what the difference was between this control:

https://github.com/oarrabi/OAStackView

@tomvanzummeren
Copy link
Owner

To be honest, I didn't know about OAStackView, but now that I do I can give you a comparison.

My implementation aims to do the same as OAStackView, but my implementation:

- supports all distributions

  • is written in Swift
  • supports layoutMarginsRelativeArrangement
  • supports animating hidden=true
  • has an extended test suite that compares the produced nslayoutconstraints against what the original UIStackView produces. So I can 100% guarantee the same behavior.

The only benefit of OAStackView is that it supports iOS 6 because it's written in obj c. Apart from that, no benefits compared to mine.

@pjebs
Copy link
Author

pjebs commented Jun 21, 2015

@pjebs
Copy link
Author

pjebs commented Jun 21, 2015

Your drop in replacement feature is the most important feature.

@pjebs pjebs closed this as completed Jun 22, 2015
@mikejurka
Copy link

I tried using OAStackView and I was running into bugs with it its intrinsic content size. Also, it seems to use auto-layout under-the-hood which seems a bit silly to me; TZStackView seems to be doing more direct layout. I ended up using TZStackView in my project.

I'm using TZStackView from Objective-C btw.

@tomvanzummeren
Copy link
Owner

TZStackView also uses auto layout, but instead it mimics the constraints EXACTLY of the official UIStackView in iOS 9. The reason OAStackView is buggy is because it does not, instead it tried to reinvent the wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants