Dynamic Tags - Post Meta Field Key names are being modified

[diggeddy]

Description

Multiple meta keys with names that:

a) contain underscores
b) start the same e.g

parent_key
parent_key_subfield
parent_key_subfield_subfield

Dynamic tags is replacing secondary underscores with a dot (.)

Here are some examples using ACF fields

toolbar_options
toolbar_options_photo => toolbar_options.photo
toolbar_options_photo_description => toolbar_options.photo_description

[iansvo]

@diggeddy The real reason this is happening is because we assume that keys named in this way are group fields. In ACF terms, if you had a group called la_bamba and then had a subfield called bazinga the stored name is: la_bamba_bazinga. We currently determine this by simply checking the name, instead of a more robust solution that would check the field type or something like that. This type of thing can probably be done better but it should hopefully be relative simple to do.

[codysmith44]

@iansvo I discovered this and was talking to Ying about it via email. The reason I do this is because sometimes I'll use the same field name across different field groups, and this makes it easier for me to identify, sort of like a prefix for where things belong. I rarely use group fields (subfields) and didn't think about the consequences of how ACF subfields work/store names.

For now I've just been manually changing the '.' to an underscore - not a huge deal but would be nice if the system just worked. Thanks!

[diggeddy]

@codysmith44 we will review and remove or correct our "assumptions" so it does just work as it should.
Thanks for bringing the issue to our attention.