Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From<AsciiString> for Cow<'static, AsciiStr> could be impl<'a> From<AsciiString> for Cow<'a, AsciiStr> #110

Open
DanikVitek opened this issue Jan 29, 2025 · 0 comments · May be fixed by #111
Open

impl From<AsciiString> for Cow<'static, AsciiStr> could be impl<'a> From<AsciiString> for Cow<'a, AsciiStr> #110

DanikVitek opened this issue Jan 29, 2025 · 0 comments · May be fixed by #111

Comments

@DanikVitek
Copy link

DanikVitek commented Jan 29, 2025 •
edited
Loading

This would likely broaden the conversion abilities and would be a just patch release
DanikVitek added a commit to DanikVitek/rust-ascii that referenced this issue Jan 29, 2025
@DanikVitek
fix: impl<'a> From<AsciiString> for Cow<'a, AsciiStr>
07c8e8e 
Fixes tomprogrammer#110

Modify the implementation of `From<AsciiString>` for `Cow<'a, AsciiStr>`.

* Change `impl From<AsciiString> for Cow<'static, AsciiStr>` to `impl<'a> From<AsciiString> for Cow<'a, AsciiStr>` in `src/ascii_string.rs`
* Broaden the conversion abilities by making it generic over any lifetime `'a`

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/tomprogrammer/rust-ascii/issues/110?shareId=XXXX-XXXX-XXXX-XXXX).
@DanikVitek DanikVitek linked a pull request Jan 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: impl<'a> From<AsciiString> for Cow<'a, AsciiStr> DanikVitek/rust-ascii
1 participant
@DanikVitek