Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected dot is not updated after removing an item from ViewPager2 #73

Closed
vkotovv opened this issue Dec 25, 2019 · 1 comment
Closed

Selected dot is not updated after removing an item from ViewPager2 #73

vkotovv opened this issue Dec 25, 2019 · 1 comment
Assignees
@tommybuonomo
Labels
bug
Milestone
4.3

Comments

@vkotovv
Copy link

vkotovv commented Dec 25, 2019 •
edited
Loading

For some reason, if I remove the first item from my ViewPager2, the dots count is updated, but the indicator' selected item is not updated (no dots are selected, I'm using DotsIndicator with different selected color). I'm calling adapter.notifyDataSetChanged() after removing the item. I'm expecting the first item to be selected.

What could be the issue? I'm using version 4.1.2

I also modified the sample to reproduce this bug, take a look at this branch (first DotsIndicator) - https://github.com/vkotovv/dotsindicator/tree/viewpager2-mutablelist-bug
@vkotovv vkotovv mentioned this issue Dec 25, 2019
Closed
@cocoahero cocoahero mentioned this issue Feb 20, 2020
Closed
@aloj22 aloj22 mentioned this issue Mar 25, 2021
Closed
@tommybuonomo tommybuonomo added this to the 4.3 milestone Apr 30, 2022
@tommybuonomo tommybuonomo self-assigned this Apr 30, 2022
@tommybuonomo
Copy link
Owner

Hello, thanks for your contribution !
This issue is now fixed in the new version 4.3
Thanks 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommybuonomo tommybuonomo

Labels
bug
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
2 participants
@vkotovv @tommybuonomo