toml-edit - stack overflow in testsuite.

[plugwash]

Hi,

I've been looking at updating the rust-toml-edit package in Debian, however when running the testsuite for the new version I get a stack overflow.

cargo test --test testsuite

thread 'stackoverflow::array_recursion_limit' has overflowed its stack
fatal runtime error: stack overflow

We are using rustc 1.70

If this was happening on some obscure architecture, I'd put it down to the weirdness of said architecture but this is happening on amd64, and it's happening even when none of our patches are applied.

Any advice would be appreciated.

[epage]

That is strange considering it isn't overflowing in our test suite and we haven't heard from any users that it is overflowing.

That test is creating a 300-levels deep TOML array and making sure we hit our 128-levels deep recursion limit.

What is the old and new version being tested?

[plugwash]

The update I was working from was from toml-edit 0.19.14 to 0.21.0

However, investigating in more detail, it seems that we were not previously running these tests. We have a patch to disable tests that either we do not carry the dependencies for, or that require test data that is not included in the crates.io releases. When I updated said patch for the new upstream version, some tests that were previously disabled ended up enabled.

When I remove our patches I can reproduce the issue with 0.19.14 as well.

Also I can only reproduce this in debug mode not release mode.

I just took a look at your CI and it seems your CI is testing toml_edit with --no-default-features and with --all-features, but never testing the default configuration. The test in question is skipped in the no-default features configuration because it has feature requirements specified in Cargo.toml and is skipped in the all features configuration because it has an explicit cfg disabling it in that case.

Edit: seems I was wrong, it seems default features for toml_edit are tested in the same workflow item as default features for "toml"

[epage]

Also I can only reproduce this in debug mode not release mode.

We only test in debug mode, so thats not helping.

That is confusing.

[epage]

Could you be enabling the unbounded feature?

Could you provide a reproduction case?

[epage]

Without a reproduction case, I'm closing