Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update implementation section with compliance information #477

Closed
ooxi opened this issue Aug 16, 2017 · 4 comments
Closed

Please update implementation section with compliance information #477

ooxi opened this issue Aug 16, 2017 · 4 comments

Comments

@ooxi
Copy link

ooxi commented Aug 16, 2017

Please update the implementation section with information about compliance as generated by toml-test. For example the most popular PHP TOML library does not support essential features like inline tables or nested tables.

@a-teammate a-teammate mentioned this issue Oct 14, 2017
26 tasks
@pradyunsg
Copy link
Member

This would be partially addressed by #430 -- where it could be noted that this is the case.

@pradyunsg
Copy link
Member

pradyunsg commented Nov 23, 2017

Or... The libraries should note which version of TOML they support. I think that's a much cleaner way to do this.

Maybe if we split out the lists at the end of the document to another separate document, it would make sense to have a note there that the libraries should be the ones to document which version of TOML they support.

@alexcrichton
Copy link
Contributor

@pradyunsg it looks like this may be mostly covered with the move from the readme to the wiki, but I'd also say that I personally at least found the version compliance in the wiki pretty useful as it allows you to just glance at "up to date parsers" which while not relevant years after 1.0 is still relevant for toml which is a slightly changing specification. I wonder if perhaps something like a year after 1.0 the wiki is gc'd (aka archived) and then all parsers are assumed to state their compliance as long as it's minimum 1.0?

@ooxi
Copy link
Author

ooxi commented Nov 29, 2017

I no longer have my test case available, however I think the library I used claimed to be 0.4.0 compatible while not supporting inline or nested tables.

Since I currently do not have the time to do a compliance test myself, I'm closing this issue.

@ooxi ooxi closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants