Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Precooking" Node Modules only works if addon uses expected Ember CLI version #213

Open
jelhan opened this issue Aug 17, 2019 · 1 comment

Comments

@jelhan
Copy link
Contributor

jelhan commented Aug 17, 2019

I'm not 100%ly sure how the script for precooking node modules should be used. I've run it from an addon that depends on ember-cli-addon-tests by executing node ./node_modules/ember-cli-addon-tests/scripts/precook-node-modules.js. In that case the script picks up ember-cli from the hosting addon not the configured here. If that doesn't equal the expected one, this results in an dependency error thrown by ember-cli-dependency-checker.

@mansona
Copy link

mansona commented Mar 29, 2021

omg I just got burned by this 🙈

I guess the simplest thing to do here would be to warn people when running the precook script of this scenario 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants