Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results: title match first #314

Open
monperrus opened this issue Aug 28, 2024 · 2 comments
Open

Search results: title match first #314

monperrus opened this issue Aug 28, 2024 · 2 comments
Labels
enhancement fixed in next release Fixed commited and, maybe even a pre-release available.

Comments

@monperrus
Copy link
Contributor

Hi Davo,

A very useful feature of tomboy is that in the search results:

  • first, the notes with title match are given
  • then, the notes with body match

Would be great to have this in ng as well.

Thanks!

@davidbannon
Copy link
Member

Hi Martin, sorry, not ignoring this question, been distracted.

Surprisingly, this is a difficult thing to implement. The "ListView" component you see the list of notes in is run in Virtual Mode, that means it does not contain all the data you expect, just that data that is visible now. As you scroll (or click the direction filters) fresh data is drawn from the main note database via several indexes. The issue here is that some users have huge (>20K) numbers of notes and the listview slows down badly if used directly.

Generating those index files is a very highly tuned process, multithreaded and optimized to ensure its quick.

As an alternative (but, IMHO less satisfactory) approach, how about an option (button, top right of Search Form) to search either title only or whole note ? Would need some (visible) way of reminding user of mode they are in ....

I do agree your suggestion is a good idea, not sure I want to slow down those index files however.

Davo

@monperrus
Copy link
Contributor Author

As an alternative (but, IMHO less satisfactory) approach, how about an option (button, top right of Search Form) to search either title only or whole note ?

not as good as the tomboy-og option but still useful!

thanks Davo

@davidbannon davidbannon added the fixed in next release Fixed commited and, maybe even a pre-release available. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed in next release Fixed commited and, maybe even a pre-release available.
Projects
None yet
Development

No branches or pull requests

2 participants