Hamburger menu close button refinements

[tomayac]

• It gets rendered outside of the menu on iOS.
• It should remain at a fixed position when scrolling.

[tomayac]

Hello @georapbox! Are you interested in working on this?

[georapbox]

Hi @tomayac! I'll have a look when I find some time, hopefully today!

[tomayac]

Absolutely no pressure, take whatever time you need, or just say "no", too.

[tomayac]

The iOS issue:

[georapbox]

Regarding having the button in fixed position, there are might be some edge cases that the button might fall over other elements. This can happen in very small viewports in combination to other languages, eg Greek where the words are longer. The minimum I can do is to provide a background color to button so that at least it does not look bad if that happens. Would that be a viable solution? Otherwise, I guess that we would need to follow another approach, like wrapping the button in another fixed positioned element with a background color that would act as a menu header and push the menu's content a few pixels lower.

[tomayac]

I guess in the interest of screen real estate, adding a background color and making the button float on top would work best here.

[tomayac]

Fixed via #45