-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to easily close options panel #37
Comments
Oh, this looks like a regression since I changed the sidebar width ( Line 354 in 31eb06e
width before). Now the "Reset All" button consumes the entire space.
The actual idea was to make the summary occupy the entire space that is not the sidebar when it's open, so the user can click anywhere (they actually click the Lines 193 to 204 in 31eb06e
I'm not opposed to adding an explicit "Close" button, so the user can either click "anywhere" or use the button. I'd be happy to merge a PR that tackles this. Thanks in advance! |
You're right, the I will prepare a PR and we can discuss further. Thanks! |
Fixed via #38. |
Description
In mobile views, when the options panel is open and options are expanded, it's a bit difficult for the user to close the panel. The panel can be closed if the user clicks outside, but It in order to achieve this they need to collapse one or more options, so that the panel's height becomes smaller and the clickable area increases.
Please see attached screenshot. Red rectangles represent the clickable areas.
The text was updated successfully, but these errors were encountered: