Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak!!! #349

Closed
timdeschryver opened this issue Sep 21, 2018 · 1 comment
Closed

Memory leak!!! #349

timdeschryver opened this issue Sep 21, 2018 · 1 comment
Labels
good first issue 🥇 help wanted 👋

Comments

@timdeschryver
Copy link
Collaborator

timdeschryver commented Sep 21, 2018 •
edited
Loading

Currently there is a memory leak inside the CRUD component.
Because memory leaks aren't really our thing, we would prefer not to have one.

You can watch Kwinten's talk Keep your memor(ies|y) safe! from NgTalks 2018 to learn how to track memory leaks and how to solve them.

Leave a comment if you would like to take this issue.
@simply10w
Copy link
Contributor

simply10w commented Sep 21, 2018 •
edited
Loading

I created a PR here:

#351

After profiling don't see memory rising when switching between crud tab and theming tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🥇 help wanted 👋
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simply10w @timdeschryver