Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde support #188

Open
mkpankov opened this issue Apr 17, 2018 · 1 comment
Open

serde support #188

mkpankov opened this issue Apr 17, 2018 · 1 comment

Comments

@mkpankov
Copy link
Contributor

Hi. I'm working on a Lua-based test engine and I'd like to make it as general as possible. So I intend to return and serialize an AnyLuaValue to JSON for another process to parse that JSON and make sense of the script result.

What's your stance on implementing serde for AnyLuaValue in-crate here? I tried using serde foreign types support and that seems to work, but I figured this functionality would benefit other people as well.

I can work on that myself but I'd like to make sure PR lands in such case, so that it's not wasted effort.

Would you accept serde implementation under an optional Cargo feature?

@tomaka
Copy link
Owner

tomaka commented Apr 18, 2018

Would you accept serde implementation under an optional Cargo feature?

Yes! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants