Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust languages pagination to fetch all languages #3311

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

stepan662
Copy link
Collaborator

Fetch all the languages (1000 should be enough)

@stepan662 stepan662 marked this pull request as ready for review February 8, 2024 10:30
@stepan662 stepan662 linked an issue Feb 8, 2024 that may be closed by this pull request
@stepan662 stepan662 requested a review from JanCizmar February 8, 2024 10:31
@jdimeo
Copy link

jdimeo commented Feb 8, 2024

1000 should be enough

Challenge accepted :-)

@stepan662 stepan662 merged commit a8e4f34 into main Feb 8, 2024
25 checks passed
@stepan662
Copy link
Collaborator Author

There is a build-in limit for pagination, so I can't fetch more than 1000 now, however if you reach that, we'll need to create a new endpoint for the languages without pagination, or solve it somehow differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only 20 languages/a single page are fetched
2 participants