Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: observer works inside shadowDom #3163

Merged
merged 4 commits into from
Feb 22, 2023
Merged

feat: observer works inside shadowDom #3163

merged 4 commits into from
Feb 22, 2023

Conversation

stepan662
Copy link
Collaborator

No description provided.

@stepan662 stepan662 linked an issue Feb 22, 2023 that may be closed by this pull request
Synchronoize updateHighlight to use the same root element defined in observerOptions #3161
Closed
@stepan662 stepan662 added the check-examples Trigger publish examples label Feb 22, 2023
@stepan662 stepan662 marked this pull request as ready for review February 22, 2023 14:50
JanCizmar
JanCizmar approved these changes Feb 22, 2023
View reviewed changes
packages/core/src/__test/plugins.test.ts Outdated Show resolved Hide resolved
@stepan662 stepan662 merged commit b9d61c4 into main Feb 22, 2023
@stepan662 stepan662 deleted the stepangranat/observer-shadow-dom branch February 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanCizmar JanCizmar JanCizmar approved these changes

Assignees
No one assigned
Labels
check-examples Trigger publish examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronoize updateHighlight to use the same root element defined in observerOptions
2 participants
@stepan662 @JanCizmar