Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump MSRV to 1.56 #2546

Merged
merged 1 commit into from
Apr 5, 2023
Merged

chore: bump MSRV to 1.56 #2546

merged 1 commit into from
Apr 5, 2023

Conversation

davidbarsky
Copy link
Member

As part of upgrading syn to 2.0 (e.g., #2516), we need to bump the MSRV to 1.56. As part of this PR, I've:

  • Updated the text descriptions of what would be an in-policy MSRV bump to use more recent versions of rustc. The niceness of said version numbers are purely coincidental.
  • I've removed some of the exceptions made in CI.yml in order to support some crates with a higher MSRV.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@hawkw
Copy link
Member

hawkw commented Apr 5, 2023

Clippy's mad about something but we should fix that separately.

@hawkw hawkw merged commit 1406b4c into master Apr 5, 2023
@hawkw hawkw deleted the david/bump-msrv-to-1.56 branch April 5, 2023 18:19
davidbarsky added a commit that referenced this pull request Sep 26, 2023
As part of upgrading syn to 2.0 (e.g.,
#2516), we need to bump the MSRV
to 1.56. As part of this PR, I've:
- Updated the text descriptions of what would be an in-policy MSRV bump
  to use more recent versions of rustc. The _niceness_ of said version
  numbers are purely coincidental.
- I've removed some of the exceptions made in CI.yml in order to support
  some crates with a higher MSRV.
davidbarsky added a commit that referenced this pull request Sep 27, 2023
As part of upgrading syn to 2.0 (e.g.,
#2516), we need to bump the MSRV
to 1.56. As part of this PR, I've:
- Updated the text descriptions of what would be an in-policy MSRV bump
  to use more recent versions of rustc. The _niceness_ of said version
  numbers are purely coincidental.
- I've removed some of the exceptions made in CI.yml in order to support
  some crates with a higher MSRV.
davidbarsky added a commit that referenced this pull request Sep 27, 2023
As part of upgrading syn to 2.0 (e.g.,
#2516), we need to bump the MSRV
to 1.56. As part of this PR, I've:
- Updated the text descriptions of what would be an in-policy MSRV bump
  to use more recent versions of rustc. The _niceness_ of said version
  numbers are purely coincidental.
- I've removed some of the exceptions made in CI.yml in order to support
  some crates with a higher MSRV.
hawkw pushed a commit that referenced this pull request Oct 1, 2023
As part of upgrading syn to 2.0 (e.g.,
#2516), we need to bump the MSRV
to 1.56. As part of this PR, I've:
- Updated the text descriptions of what would be an in-policy MSRV bump
  to use more recent versions of rustc. The _niceness_ of said version
  numbers are purely coincidental.
- I've removed some of the exceptions made in CI.yml in order to support
  some crates with a higher MSRV.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants