Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove misleading doc #2220

Merged
merged 2 commits into from
Jul 14, 2022
Merged

doc: remove misleading doc #2220

merged 2 commits into from
Jul 14, 2022

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Jul 14, 2022

There's no automated propagation of subscrbibers between spans, you have
to do this manually.

https://discord.com/channels/500028886025895936/997201342596657232/997210656677830778

There's no automated propagation of subscrbibers between spans, you have
to do this manually.

https://discord.com/channels/500028886025895936/997201342596657232/997210656677830778
@matklad matklad requested review from hawkw, davidbarsky and a team as code owners July 14, 2022 18:47
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, one small suggestion

tracing/src/collect.rs Show resolved Hide resolved
tracing/src/collect.rs Show resolved Hide resolved
@hawkw hawkw enabled auto-merge (squash) July 14, 2022 19:36
@hawkw hawkw merged commit 968dd0d into tokio-rs:master Jul 14, 2022
@matklad matklad deleted the docs branch July 15, 2022 16:55
hawkw added a commit that referenced this pull request Jul 20, 2022
There's no automated propagation of subscribers between spans, you have
to do this manually.

https://discord.com/channels/500028886025895936/997201342596657232/997210656677830778

Co-authored-by: Eliza Weisman <[email protected]>
hawkw added a commit that referenced this pull request Jul 20, 2022
There's no automated propagation of subscribers between spans, you have
to do this manually.

https://discord.com/channels/500028886025895936/997201342596657232/997210656677830778

Co-authored-by: Eliza Weisman <[email protected]>
hawkw added a commit that referenced this pull request Jul 20, 2022
There's no automated propagation of subscribers between spans, you have
to do this manually.

https://discord.com/channels/500028886025895936/997201342596657232/997210656677830778

Co-authored-by: Eliza Weisman <[email protected]>
hawkw added a commit that referenced this pull request Jul 29, 2022
# 0.1.36 (July 29, 2022)

This release adds support for owned values and fat pointers as arguments
to the `Span::record` method, as well as updating the minimum
`tracing-core` version and several documentation improvements.

### Fixed

- Incorrect docs in `dispatcher::set_default` ([#2220])
- Compilation with `-Z minimal-versions` ([#2246])

### Added

- Support for owned values and fat pointers in `Span::record` ([#2212])
- Documentation improvements ([#2208], [#2163])

### Changed

- `tracing-core`: updated to [0.1.29][core-0.1.29]

Thanks to @fredr, @cgbur, @jyn514, @matklad, and @CAD97 for contributing
to this release!

[core-0.1.29]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.29
[#2220]: #2220
[#2246]: #2246
[#2212]: #2212
[#2208]: #2208
[#2163]: #2163
hawkw added a commit that referenced this pull request Jul 29, 2022
# 0.1.36 (July 29, 2022)

This release adds support for owned values and fat pointers as arguments
to the `Span::record` method, as well as updating the minimum
`tracing-core` version and several documentation improvements.

### Fixed

- Incorrect docs in `dispatcher::set_default` ([#2220])
- Compilation with `-Z minimal-versions` ([#2246])

### Added

- Support for owned values and fat pointers in `Span::record` ([#2212])
- Documentation improvements ([#2208], [#2163])

### Changed

- `tracing-core`: updated to [0.1.29][core-0.1.29]

Thanks to @fredr, @cgbur, @jyn514, @matklad, and @CAD97 for contributing
to this release!

[core-0.1.29]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.29
[#2220]: #2220
[#2246]: #2246
[#2212]: #2212
[#2208]: #2208
[#2163]: #2163
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
There's no automated propagation of subscribers between spans, you have
to do this manually.

https://discord.com/channels/500028886025895936/997201342596657232/997210656677830778

Co-authored-by: Eliza Weisman <[email protected]>
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.1.36 (July 29, 2022)

This release adds support for owned values and fat pointers as arguments
to the `Span::record` method, as well as updating the minimum
`tracing-core` version and several documentation improvements.

### Fixed

- Incorrect docs in `dispatcher::set_default` ([tokio-rs#2220])
- Compilation with `-Z minimal-versions` ([tokio-rs#2246])

### Added

- Support for owned values and fat pointers in `Span::record` ([tokio-rs#2212])
- Documentation improvements ([tokio-rs#2208], [tokio-rs#2163])

### Changed

- `tracing-core`: updated to [0.1.29][core-0.1.29]

Thanks to @fredr, @cgbur, @jyn514, @matklad, and @CAD97 for contributing
to this release!

[core-0.1.29]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.29
[tokio-rs#2220]: tokio-rs#2220
[tokio-rs#2246]: tokio-rs#2246
[tokio-rs#2212]: tokio-rs#2212
[tokio-rs#2208]: tokio-rs#2208
[tokio-rs#2163]: tokio-rs#2163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants