Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme remove hard coded version link #2208

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Readme remove hard coded version link #2208

merged 2 commits into from
Jul 12, 2022

Conversation

cgbur
Copy link
Contributor

@cgbur cgbur commented Jul 6, 2022

Motivation

When a user clicks they they may accidentally get an old version of the crate. Its also out of sync with the current main readme.

Solution

removed the hard coded links

@cgbur cgbur requested review from hawkw, davidbarsky and a team as code owners July 6, 2022 19:14
@bryangarza bryangarza enabled auto-merge (squash) July 12, 2022 15:57
@bryangarza bryangarza self-requested a review July 12, 2022 15:57
@bryangarza bryangarza merged commit 8cf8175 into tokio-rs:master Jul 12, 2022
@bryangarza
Copy link
Member

Thanks for the PR Chris. FYI during the squash-merge I renamed the first line of the commit message to match the contributing guidelines

@davidbarsky
Copy link
Member

Two notes:

  • We haven't done releases from the master branch in a little bit because tracing 0.2 is taking a little bit longer than expected.
  • We've historically had these links in the README.md because an older version on crates.io would link to the version-appropriate documentation.

This is done correctly on the v0.1.0 branch: https://github.com/tokio-rs/tracing/tree/v0.1.x, so we won't need a backport.

hawkw pushed a commit that referenced this pull request Jul 20, 2022
Motivation:
When a user clicks they they may accidentally get an old version of the
crate. Its also out of sync with the current main readme.

Solution:
removed the hard coded links
hawkw pushed a commit that referenced this pull request Jul 20, 2022
Motivation:
When a user clicks they they may accidentally get an old version of the
crate. Its also out of sync with the current main readme.

Solution:
removed the hard coded links
hawkw pushed a commit that referenced this pull request Jul 20, 2022
Motivation:
When a user clicks they they may accidentally get an old version of the
crate. Its also out of sync with the current main readme.

Solution:
removed the hard coded links
hawkw added a commit that referenced this pull request Jul 29, 2022
# 0.1.36 (July 29, 2022)

This release adds support for owned values and fat pointers as arguments
to the `Span::record` method, as well as updating the minimum
`tracing-core` version and several documentation improvements.

### Fixed

- Incorrect docs in `dispatcher::set_default` ([#2220])
- Compilation with `-Z minimal-versions` ([#2246])

### Added

- Support for owned values and fat pointers in `Span::record` ([#2212])
- Documentation improvements ([#2208], [#2163])

### Changed

- `tracing-core`: updated to [0.1.29][core-0.1.29]

Thanks to @fredr, @cgbur, @jyn514, @matklad, and @CAD97 for contributing
to this release!

[core-0.1.29]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.29
[#2220]: #2220
[#2246]: #2246
[#2212]: #2212
[#2208]: #2208
[#2163]: #2163
hawkw added a commit that referenced this pull request Jul 29, 2022
# 0.1.36 (July 29, 2022)

This release adds support for owned values and fat pointers as arguments
to the `Span::record` method, as well as updating the minimum
`tracing-core` version and several documentation improvements.

### Fixed

- Incorrect docs in `dispatcher::set_default` ([#2220])
- Compilation with `-Z minimal-versions` ([#2246])

### Added

- Support for owned values and fat pointers in `Span::record` ([#2212])
- Documentation improvements ([#2208], [#2163])

### Changed

- `tracing-core`: updated to [0.1.29][core-0.1.29]

Thanks to @fredr, @cgbur, @jyn514, @matklad, and @CAD97 for contributing
to this release!

[core-0.1.29]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.29
[#2220]: #2220
[#2246]: #2246
[#2212]: #2212
[#2208]: #2208
[#2163]: #2163
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.1.36 (July 29, 2022)

This release adds support for owned values and fat pointers as arguments
to the `Span::record` method, as well as updating the minimum
`tracing-core` version and several documentation improvements.

### Fixed

- Incorrect docs in `dispatcher::set_default` ([tokio-rs#2220])
- Compilation with `-Z minimal-versions` ([tokio-rs#2246])

### Added

- Support for owned values and fat pointers in `Span::record` ([tokio-rs#2212])
- Documentation improvements ([tokio-rs#2208], [tokio-rs#2163])

### Changed

- `tracing-core`: updated to [0.1.29][core-0.1.29]

Thanks to @fredr, @cgbur, @jyn514, @matklad, and @CAD97 for contributing
to this release!

[core-0.1.29]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.29
[tokio-rs#2220]: tokio-rs#2220
[tokio-rs#2246]: tokio-rs#2246
[tokio-rs#2212]: tokio-rs#2212
[tokio-rs#2208]: tokio-rs#2208
[tokio-rs#2163]: tokio-rs#2163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants