Skip to content

Commit

Permalink
subscriber: update minimum tracing-core dep to 0.1.28 (#2190)
Browse files Browse the repository at this point in the history
## Motivation

PR #2008 added a new method to the `tracing_core::Subscriber` trait, and
modified `tracing-subscriber` to and implement that method. However,
that PR did *not* increase the minimum `tracing-core` dependency for the
`tracing-subscriber` crate.

This means that if a dependent of `tracing-subscriber` updates *only*
`tracing-subscriber` dependency version (e.g. by running
`cargo update -p tracing-subscriber`), it will not also update its
`tracing-core` version to one that contains the new method, and
`tracing-subscriber` will fail to compile. This is a common occurrence
with projects using Dependabot, for example.

## Solution

This commit updates `tracing-subscriber`'s minimum `tracing-core` dep to
0.1.28. Once this merges, I'll release 0.3.13 of `tracing-subscriber`
and yank 0.3.12.
  • Loading branch information
hawkw authored Jun 30, 2022
1 parent d86d2a4 commit b4680b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tracing-subscriber/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ valuable = ["tracing-core/valuable", "valuable_crate", "valuable-serde", "tracin
local-time = ["time/local-offset"]

[dependencies]
tracing-core = { path = "../tracing-core", version = "0.1.22", default-features = false }
tracing-core = { path = "../tracing-core", version = "0.1.28", default-features = false }

# only required by the filter feature
tracing = { optional = true, path = "../tracing", version = "0.1", default-features = false }
Expand Down

0 comments on commit b4680b1

Please sign in to comment.