Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: add read_buf_exact to AsyncReadExt #7130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

io: add read_buf_exact to AsyncReadExt #7130

wants to merge 2 commits into from
+176 −0

Conversation

maminrayej
Copy link
Member

Resolves #7127.

@maminrayej maminrayej added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Jan 27, 2025
Darksonn
Darksonn reviewed Jan 28, 2025
View reviewed changes
tokio/tests/io_read_buf_exact.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that uses this with Vec<u8> and BytesMut too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that we might need to supply the number of bytes as a separate parameter. I recall that resizable buffers are considered infinitely large by BufMut.

@maminrayej maminrayej mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please provide a read_buf_exact helper
2 participants
@maminrayej @Darksonn