Add AsyncFd::with_interest #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
reviewed
Nov 23, 2020
tokio/src/io/async_fd.rs
Outdated
| pub(crate) fn new_with_handle(inner: T, handle: Handle) -> io::Result<Self> { | ||
| /// Creates new instance as `new` with additional ability to customize interest, | ||
| /// allowing to specify whether file descriptor will be polled for read, write or both. | ||
| pub fn new_with_interest(inner: T, interest: Interest) -> io::Result<Self> |
There was a problem hiding this comment.
Thanks, I'm wondering if this should just be with_interest (modeling after Vec::with_capacity).
The other new_with fns are internal and haven't received as much attention naming wise.
Thoughts @tokio-rs/maintainers ?
There was a problem hiding this comment.
i have a slight preference for with_interest, but i could be convinced otherwise.
There was a problem hiding this comment.
Changed it to with_interest, it is shorter too so I would prefer it
Darksonn
added
A-tokio
Darksonn
approved these changes
Nov 28, 2020
| } | ||
|
|
||
| pub(crate) fn new_with_handle(inner: T, handle: Handle) -> io::Result<Self> { | ||
| pub(crate) fn new_with_handle_and_interest( |
There was a problem hiding this comment.
We may also want to rename this to with_handle_and_interest for consistency, but definitely not a blocker. I will merge this shortly if nobody has any other comments.
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
Interestcustomization forAsyncFdFixes #3072