From 28d26ebc84df492bd64464ac63844b0a58f49ac2 Mon Sep 17 00:00:00 2001 From: Hayden Stainsby Date: Tue, 3 Dec 2024 19:27:34 +0100 Subject: [PATCH] Remove expectation of duration value from sleep test The value isn't stable, and never made sense in the first place (sleep for 7 milliseconds and get a `duration.op` of 8?!?!). --- tokio/tests/tracing_time.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tokio/tests/tracing_time.rs b/tokio/tests/tracing_time.rs index 964077ff278..a227cde7a73 100644 --- a/tokio/tests/tracing_time.rs +++ b/tokio/tests/tracing_time.rs @@ -22,7 +22,10 @@ async fn test_sleep_creates_span() { .with_target("runtime::resource::state_update") .with_fields( expect::field("duration") - .with_value(&(7_u64 + 1)) + // FIXME(hds): This value isn't stable and doesn't seem to make sense. We're not + // going to test on it until the resource instrumentation has been + // refactored and we know that we're getting a stable value here. + //.with_value(&(7_u64 + 1)) .and(expect::field("duration.op").with_value(&"override")), );