Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributes just to messages. #477

Closed
wants to merge 1 commit into from
Closed

Add attributes just to messages. #477

wants to merge 1 commit into from

Conversation

jozn
Copy link

@jozn jozn commented May 15, 2021

This add attributes just to Rust structs.

@jozn
Add attributes just to messages.
82c62b2 
This add attributes just to Rust structs.
@LucioFranco
Copy link
Member

Im not totally following how this approach is different than the type attributes but it would also be good to add some tests.

@jozn
Copy link
Author

jozn commented Jul 17, 2021 •
edited
Loading

Sorry for late reply.
Type attributes adds them to both rust enums and structs, this one adds attributes just to structs.
This PR is for a long time ago, at the time I needed to add some attributes to rust struct only, after this PR I have changed things and didn't need this functionality anymore. Anyway as it's not a priority for me and i'm busy with some other projects feel free to close this PR.

@LucioFranco
Copy link
Member

sorry for the delay, thanks for your PR! Closing this in favor of #522

@LucioFranco LucioFranco closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jozn @LucioFranco