close_on_drop fails not-polling assertion

[Thomasdezeeuw]

Now sure how. If I recall correctly select2 is only called by Poll::poll which takes &mut self, so it shouldn't be possible.

Happened twice already:

• https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=6689&view=logs&j=e1a083b5-91b8-5cb1-6c0a-e91e3e10d3b3&t=71005bf2-7cb4-5db7-5f41-3a8dff9954b8&l=63
• https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=6689&view=logs&j=429a383f-e486-57ac-3982-9ac65641a32a&t=34887100-476e-568c-c947-304a658b3e9f&l=47

thread 'close_on_drop' panicked at 'assertion failed: self.is_polling.swap(true, Ordering::AcqRel)', src\sys\windows\selector.rs:464:9
stack backtrace:
   0:     0x7ff69ef553af - std::backtrace_rs::backtrace::dbghelp::trace
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\..\..\backtrace\src\backtrace\dbghelp.rs:98
   1:     0x7ff69ef553af - std::backtrace_rs::backtrace::trace_unsynchronized
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2:     0x7ff69ef553af - std::sys_common::backtrace::_print_fmt
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\sys_common\backtrace.rs:67
   3:     0x7ff69ef553af - std::sys_common::backtrace::_print::impl$0::fmt
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\sys_common\backtrace.rs:46
   4:     0x7ff69ef7116a - core::fmt::write
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\core\src\fmt\mod.rs:1161
   5:     0x7ff69ef4f878 - std::io::Write::write_fmt<alloc::vec::Vec<u8,alloc::alloc::Global> >
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\io\mod.rs:1668
   6:     0x7ff69ef58006 - std::sys_common::backtrace::_print
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\sys_common\backtrace.rs:49
   7:     0x7ff69ef58006 - std::sys_common::backtrace::print
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\sys_common\backtrace.rs:36
   8:     0x7ff69ef58006 - std::panicking::default_hook::closure$1
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\panicking.rs:210
   9:     0x7ff69ef57b1d - std::panicking::default_hook
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\panicking.rs:224
  10:     0x7ff69ef58665 - std::panicking::rust_panic_with_hook
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\panicking.rs:624
  11:     0x7ff69ef5821f - std::panicking::begin_panic_handler::closure$0
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\panicking.rs:519
  12:     0x7ff69ef55ce7 - std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure$0,never$>
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\sys_common\backtrace.rs:141
                               at /rustc/98c8619502093f34ca82f8f26ccf32e753924440\/library\std\src\sys\windows\thread.rs:58
  44:     0x7ffb239484d4 - BaseThreadInitThunk
  45:     0x7ffb24ce1781 - RtlUserThreadStart

[Darksonn]

Is this related to this comment? #1514 (comment)

[Thomasdezeeuw]

@Darksonn yup, closing.