Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Sync]: using a repo url but write to a different .json #327

Closed
vkoopmans-resoluut opened this issue Nov 18, 2021 · 0 comments · Fixed by #338
Closed

[GitHub Sync]: using a repo url but write to a different .json #327

vkoopmans-resoluut opened this issue Nov 18, 2021 · 0 comments · Fixed by #338
Labels
enhancement Internal new feature or functionality

Comments

@vkoopmans-resoluut
Copy link

Describe the bug
Adding duplicate credentials to the Github Sync option, using a different .json path, leads to the plugin selecting both credentials (thinking it's the same.

To Reproduce
Steps to reproduce the behavior:

  1. Create Github credentials
  2. Create Github credentials again, similar repo but with a different target directory / json

Expected behavior
I would expect to use a single repository but write to a different target directory within it by creating 2 credentials
Brand-1/tokens.json
Brand-2/tokens.json

Screenshots or Screencasts
image

Figma file (optional)
Send us the link to a Figma file containing a reproducible example

JSON (optional)
If possible, attach the JSON that leads to this bug.

@six7 six7 added the enhancement Internal new feature or functionality label Nov 23, 2021
@six7 six7 mentioned this issue Nov 28, 2021
@six7 six7 closed this as completed in #338 Nov 28, 2021
@six7 six7 changed the title Github Sync using a repo url but write to a different .json [GitHub Sync] using a repo url but write to a different .json Dec 2, 2021
@six7 six7 changed the title [GitHub Sync] using a repo url but write to a different .json [GitHub Sync]: using a repo url but write to a different .json Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Internal new feature or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants