Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab Sync is Not Allowing Users To Push Tokens #2822

Closed
keeganedwin opened this issue Jun 7, 2024 · 0 comments · Fixed by #2854
Closed

Gitlab Sync is Not Allowing Users To Push Tokens #2822

keeganedwin opened this issue Jun 7, 2024 · 0 comments · Fixed by #2854
Assignees
Labels
2.0-rc7 bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket sync gitlab sync push fail

Comments

@keeganedwin
Copy link
Collaborator

Describe the bug
A bit of a challenge to reproduce this bug, but users using the Gitlab sync claim that every time they push tokens to the repo it doesn't actually push them; blue indicators on both push and pull icons. Or even if it does push, when they close and reopen the plugin it reverts back to a previous version. This is a major blocker for them so we need to try and get to the bottom of it asap.

It also seems to be related to the following tickets:

  1. Push/Pull Indictor Persist with Github Sync #2320
  2. When creating a new branche, unsaved changes are still visible (but they are discarded) #1636
  3. [2.0]: Pulling from remote or restarting plugin causes blue dot to instantly appear #2652

To Reproduce
Steps to reproduce the behavior:

  1. Enable gitlab sync
  2. Create/edit tokens
  3. Push tokens
  4. See error - I've both blue indicators displayed on both rc7 and the 1.38.9 the first time I tested the issue. Subsequent times not so much luck.

Screenshots or Screencasts
https://github.com/tokens-studio/figma-plugin/assets/93133012/0c888f2e-6656-4c3d-976b-0127d49c79b9

@cuserox cuserox self-assigned this Jun 7, 2024
@cuserox cuserox moved this from 📥 Triage to 📤 Ready for dev in Tokens Studio for Figma Roadmap Jun 7, 2024
@cuserox cuserox moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Jun 7, 2024
@cuserox cuserox removed their assignment Jun 11, 2024
@cuserox cuserox moved this from 🕜 In Progress to 📤 Ready for dev in Tokens Studio for Figma Roadmap Jun 11, 2024
@robinhoodie0823 robinhoodie0823 self-assigned this Jun 13, 2024
@robinhoodie0823 robinhoodie0823 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Jun 13, 2024
@robinhoodie0823 robinhoodie0823 moved this from 🕜 In Progress to 👀 Needs review in Tokens Studio for Figma Roadmap Jun 14, 2024
@six7 six7 linked a pull request Jun 15, 2024 that will close this issue
@six7 six7 closed this as completed Jun 15, 2024
@github-project-automation github-project-automation bot moved this from 👀 Needs review to ✅ Done in Tokens Studio for Figma Roadmap Jun 15, 2024
@SamIam4Hyma SamIam4Hyma added the plugin v2 variables, UI, WTCG format, Bitbucket label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-rc7 bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket sync gitlab sync push fail
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants