Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When applying Border tokens we always apply color as a hex, instead of style when available #1522

Closed
six7 opened this issue Jan 5, 2023 · 0 comments · Fixed by #1529 or #1513
Closed
Assignees
Labels
bug Something isn't working

Comments

@six7
Copy link
Collaborator

six7 commented Jan 5, 2023

Base this on release-133.

To reproduce:

  • Create a color token calledblack with a value of #000000
  • Hit Create styles so there's a color style of black
  • Create a border token called borderDefault with a value of
{
  "value": {
    "width": "3px",
    "color: "{black}"
    "style": "solid"
  }

When you now apply that border token on a layer, it is expected that the color style is applied, and only when we do not find that color style do we apply the hex value.

Instead, we currently apply the hex value.

image

image

@six7 six7 added the bug Something isn't working label Jan 5, 2023
@six7 six7 moved this to 🔜 Next up in Tokens Studio for Figma Roadmap Jan 5, 2023
@swordEdge swordEdge moved this from 🔜 Next up to 🕜 In Progress in Tokens Studio for Figma Roadmap Jan 7, 2023
@swordEdge swordEdge moved this from 🕜 In Progress to 👀 Needs review in Tokens Studio for Figma Roadmap Jan 9, 2023
@swordEdge swordEdge self-assigned this Jan 9, 2023
@six7 six7 mentioned this issue Jan 9, 2023
@six7 six7 moved this from 👀 Needs review to 🤞 To be released in Tokens Studio for Figma Roadmap Jan 10, 2023
@github-project-automation github-project-automation bot moved this from 🤞 To be released to ✅ Done in Tokens Studio for Figma Roadmap Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
2 participants