Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchable Token suggestion dropdown #1437

Closed
cscheffauer opened this issue Nov 18, 2022 · 6 comments
Closed

Searchable Token suggestion dropdown #1437

cscheffauer opened this issue Nov 18, 2022 · 6 comments

Comments

@cscheffauer
Copy link

Is your feature request related to a problem? Please describe.
The problem currently is that if u are mapping tokens to other tokens, the suggestion dropdown doesn't allow searching or typeahead such that a user always needs to either scroll or recall the exact token name.

image

Describe the solution you'd like
A way to search in the suggestion dropdown

Describe alternatives you've considered
/

Additional context
Not quite sure if this is already possible somehow?

@six7
Copy link
Collaborator

six7 commented Nov 18, 2022

Thanks for reporting, yeah I think we'll want to do some improvements to that component so you can keep typing. Ideally suggest and the dropdown do 2 different things.

Suggest: Autocomplete the current typed value after you typed {
Pick: Give a popover that lets me search and pick tokens

@cscheffauer
Copy link
Author

@six7 thanks - is this something you look into working on?

@six7
Copy link
Collaborator

six7 commented Nov 27, 2022

@six7 thanks - is this something you look into working on?

Yes, we're a bit blocked by #1203 but once that is out of the way there'll be these two modes of suggest/search.

Contributions are always welcome if that's something you'd like to see fixed sooner 🙏

@cscheffauer
Copy link
Author

@six7 thanks - is this something you look into working on?

Yes, we're a bit blocked by #1203 but once that is out of the way there'll be these two modes of suggest/search.

Contributions are always welcome if that's something you'd like to see fixed sooner 🙏

Thanks a lot! :) i will have a look at the contribution guide at some point and see if I can help.

@esreverse
Copy link

esreverse commented Dec 8, 2022

@six7 May I ask a question about your first reply

Pick: Give a popover that lets me search and pick tokens

In my head it would be implemented in a way that all special characters like e.g. "." and "-" will segment a variable, so you could search for: "base.selectable.primary.bg-hover" with a string like "ba pr se ho". Does that sound like your idea of implementing it?

@six7 six7 moved this to 📥 Triage in Tokens Studio for Figma Roadmap Dec 10, 2022
@six7 six7 moved this from 📥 Triage to 🗃️ Backlog in Tokens Studio for Figma Roadmap Dec 10, 2022
@six7
Copy link
Collaborator

six7 commented Jan 8, 2023

I'm closing this in favor of #1203 which will fulfill those requirements.

@esreverse yes, that'd be ideal! added it to the requirements.

@six7 six7 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2023
@github-project-automation github-project-automation bot moved this from 🗃️ Backlog to 🕜 In Progress in Tokens Studio for Figma Roadmap Jan 8, 2023
@six7 six7 moved this from 🕜 In Progress to ✅ Done in Tokens Studio for Figma Roadmap Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants