Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-local styles: M2 #1160

Closed
4 of 6 tasks
six7 opened this issue Aug 13, 2022 · 4 comments
Closed
4 of 6 tasks

Non-local styles: M2 #1160

six7 opened this issue Aug 13, 2022 · 4 comments

Comments

@six7
Copy link
Collaborator

six7 commented Aug 13, 2022

Now that we shipped support for non-local styles in version 114, we should plan ahead for the next iteration of this feature.

Tasks for M2

If you've used non-local styles and have any feedback for us, leave your feedback in this issue 🙏

@lmjabreu
Copy link

What's the best resource to understand how to use non-local styles?

I was a developer for 10 years or so, now I deal with design systems, and I'm quite confused by this plugin 😅

In the immediate future, my team would benefit from being able to switch themes, just colour styles to being with.

I'd expect to be able to use this plugin in this way:

  1. Run the plugin in the file containing the source colour styles
  2. Import the styles so we can manipulate them into themes
    1. Import local colour styles: Styles > Import (local) Styles
    2. Save to GitHub (optional)
    3. Create a set or theme: e.g. duplicate original set containing Light + Dark themes, rename the new set to Light, delete dark colour styles in that set (e.g. Dark/Actionable/...). Rename the original set to Dark and delete light colour styles (e.g. Light/Actionable/...)
  3. Toggle between sets or themes, applying them to the chosen scope
    1. Open Figma Tokens in the current or new file
    2. Toggle between Light and Dark theme
    3. Update the chose scope, e.g. currently select frame

The plugin seems to:

  1. Have long-winded processes: e.g. creating a theme requires one step to create and name, another one to attach local styles
  2. Confusing vocabulary, in the example above, local styles means styles from the currently active set, not the local file. Styles > Import Styles does import local file styles, but the local keyword is missing.
  3. Opaque mechanics and error handling: toggling settings such as "ignore first part of the token name for styles" is referring to a process that's internal to the plugin, i.e. style names are converted into tokens, even if you never use tokens. Updating the selection styles may yield no changes, then user must understand why themselves, rather than being able to consult a log (e.g. no styles updated, couldn't find matching token/style with the name Actionable )

I paid for the Pro subscription so I'd like to help improving this plugin if possible. :)

@six7
Copy link
Collaborator Author

six7 commented Oct 27, 2022

@lmjabreu best would be to check out https://docs.figmatokens.com/styles/non-local-styles

I have a feeling though that what you want will be covered by #1204

And thanks a ton for the feedback, this helps us shape it further 🙏

@lmjabreu
Copy link

@six7 I'll check that out, does look helpful 🙏

#1204 seems super relevant.

Happy to provide feedback on-demand and get my team to do the same. Thanks for all your hard work on this, much appreciated 🙇‍♂️

@six7
Copy link
Collaborator Author

six7 commented Feb 14, 2023

Closing this epic as complete and the unfinished tasks as not planned (for now)

@six7 six7 closed this as completed Feb 14, 2023
@github-project-automation github-project-automation bot moved this from 🕜 In Progress to ✅ Done in Tokens Studio for Figma Roadmap Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants