Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export doesn't include $metadata or $themes #1155

Closed
six7 opened this issue Aug 13, 2022 · 0 comments · Fixed by #1178 or #1173
Closed

Export doesn't include $metadata or $themes #1155

six7 opened this issue Aug 13, 2022 · 0 comments · Fixed by #1178 or #1173
Assignees

Comments

@six7
Copy link
Collaborator

six7 commented Aug 13, 2022

Our Export currently is missing our $themes and $metadata properties, this is different per implementation:

Image

Single file export is missing $themes object

When you export to a single file it seems we do not include the $themes object, which we should.
We should also include the $metadata object.

Image

Multi file export is missing $metadata file

When you export to a folder the created folder doesn't include the $metadata file (which is useful as we store tokenSetOrder in there, so custom order of users token sets is preserved).
This one does include the $themes object, though.

Image

What needs to change?

Single file export: Should get both $themes and $metadata object
Multi file export: Should get the $themes object
Import: We should make sure that Importing these files/folders respects these properties.

@swordEdge swordEdge self-assigned this Aug 16, 2022
@swordEdge swordEdge linked a pull request Aug 16, 2022 that will close this issue
@six7 six7 mentioned this issue Aug 19, 2022
@six7 six7 closed this as completed in 5935fea Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants