Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion dropdown doesn't appear for documentation tokens while changing to another token on the "Inspect" tab #1125

Closed
shvedetsky opened this issue Aug 5, 2022 · 6 comments · Fixed by #1229 or #1273
Assignees

Comments

@shvedetsky
Copy link

shvedetsky commented Aug 5, 2022

While trying to remap documentation tokens on the Inspect tab the dropdown with suggestions doesn't appear after I typed "{someTokeName..." https://postimg.cc/QBC7mRWs

Description (edited six7)

When trying to remap in the Inspect and the token you're trying to remap is on either of the Documentation properties (tokenName, value, rawValue, description) the modal that appears to give you suggestions doesn't show anythng.

To reproduce:

  • Apply either Documentation tokns -> tokenName, value, rawValue, description on a layer
  • Use Inspect to remap these tokens
  • Notice how the autosuggest doesn't show anything.

Expected:

  • These kinds of tokens should show all tokens
@six7
Copy link
Collaborator

six7 commented Aug 9, 2022

Can you tell me more about how you reached that state? For me this works:

Image

@shvedetsky
Copy link
Author

@six7 I reached this state just as I described. Inspect tab —> trying to remap documentation token —> don't see/get suggestion dropdown after I type symbol "{"

@six7
Copy link
Collaborator

six7 commented Aug 10, 2022

Are by chance none of your token sets marked as active?

@shvedetsky
Copy link
Author

@six7 nope, all three that I use are active always

@shvedetsky
Copy link
Author

@six7 here is video https://youtu.be/dcngtWjv-0E

@six7
Copy link
Collaborator

six7 commented Aug 14, 2022

Thank you for that video, that explains it! I'm guessing our logic that decides what tokens to show in the dropdown doesn't include tokenName or other related tokens yet.

Instead we should show all tokens when using that dropdown, same is probably true for all other Documentation tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment