-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make together embeddings.create() into OpenAI compatible format and allow providing a safety_model to Complete.create() #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to make the method compatible with openai
this is to make the method compatible with openai
this make the embedding API openai compatible so you can call embed.data[0].embedding
this make the embedding API openai compatible so you can call embed.data[0].embedding
this is for the meta safety llama as a placeholder so we can use python in the demo
not to be announced yet per heejin
this allows for both the output = together.Complete.create( form of usage and also the client = TogetherAI() embed = client.embeddings.create( form of usage to keep the python library self consistent but also be OpenAI compatible
@orangetin changed to use the client = TogetherAI() we talked about |
this allows for both the output = together.Complete.create( form of usage and also the client = TogetherAI() embed = client.embeddings.create( form of usage to keep the python library self consistent but also be OpenAI compatible
this allows for both the output = together.Complete.create( form of usage and also the client = TogetherAI() embed = client.embeddings.create( form of usage to keep the python library self consistent but also be OpenAI compatible
orangetin
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments
… and changed Output to EmbeddingsOuput black ruff and mypy
… and changed Output to EmbeddingsOuput black ruff and mypy
orangetin
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # https://linear.app/together-ai/issue/ENG-385/openai-compatibility-for-the-embeddings-endpoint
Describe your changes
Open AI does this:
With this PR, we can now do this:
or this:
In the meta safety llama, we have alot of useful python library functions for data processing, checking and uploading for finetuning, so it would be very good to also have a safety model be able to be used via the python library/CLI, so this PR allows:
Also deleted embeddings api from README.md per heejin's request, not to be revealed til launch